termcap: fix build with gcc15 #478354
Merged
termcap: fix build with gcc15 #478354
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
eljamm
commented
Jan 9, 2026
This comment was marked as outdated.
This comment was marked as outdated.
The ISO C23, which is the default in GCC 15, changes the meaning of an empty argument list from an unspecified list to no arguments, thus breaking the build. This is fixed by switching the language standard to `gnu89` (dialect of ISO C90).
eljamm
force-pushed
the
fix/termcap-gcc15
branch
from
4e20763 to
ea15d85
Compare
Member
|
Came across this in a last-minute search :P The package is indeed patchable so I suppose #479265 is better but I'm not very sure about vendoring a patch. |
Contributor
Author
I was patching this too at first, but perhaps changing the language standard is better because it's more resilient to future changes. Some distros like fedora are doing this. |
Contributor
Author
|
wegank
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ISO C23, which is the default in GCC 15, changes the meaning of an empty argument list from an unspecified list to no arguments, thus breaking the build.
This is fixed by switching the language standard to
gnu89(dialect of ISO C90).Tracking: #475479
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.